Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update default config to work out-of-the-box with flytectl demo #1384

Merged
merged 13 commits into from
Jan 10, 2023
Merged

Update default config to work out-of-the-box with flytectl demo #1384

merged 13 commits into from
Jan 10, 2023

Commits on Dec 23, 2022

  1. Update default config to work out-of-the-box with flytectl demo 

    Fixes flyteorg/flyte#3182

This PR makes the getting started UX smoother when users try to
invoke `pyflyte run` against the flytectl demo cluster. This
change means that they no longer have to `export FLYTECTL_CONFIG=...`
to get it working.

Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
    @cosmicBboy
    cosmicBboy committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    869ecd1 View commit details
    Browse the repository at this point in the history

  2. fix lint 

    Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
    @cosmicBboy
    cosmicBboy committed Dec 23, 2022
    Configuration menu
    Copy the full SHA
    8ace742 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2022

  1. Merge branch 'master' into update-default-config

    @eapolinario
    eapolinario authored Dec 28, 2022
    Configuration menu
    Copy the full SHA
    5309fe6 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2023

  1. fix tests 

    Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
    @cosmicBboy
    cosmicBboy committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    0dbb4c3 View commit details
    Browse the repository at this point in the history

Commits on Jan 4, 2023

  1. fix bug in config value reader 

    Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
    @cosmicBboy
    cosmicBboy committed Jan 4, 2023
    Configuration menu
    Copy the full SHA
    2046c8c View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. handle case of empty list 

    Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
    @cosmicBboy
    cosmicBboy committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    7bf89ef View commit details
    Browse the repository at this point in the history

  2. update 

    Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
    @cosmicBboy
    cosmicBboy committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    ebd696c View commit details
    Browse the repository at this point in the history

Commits on Jan 6, 2023

  1. add tests 

    Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
    @cosmicBboy
    cosmicBboy committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    097cc99 View commit details
    Browse the repository at this point in the history

  2. revert LegacyConfigEntry.read_from_File 

    Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
    @cosmicBboy
    cosmicBboy committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    a58c526 View commit details
    Browse the repository at this point in the history

  3. fix lint 

    Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
    @cosmicBboy
    cosmicBboy committed Jan 6, 2023
    Configuration menu
    Copy the full SHA
    03e8954 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Merge branch 'master' into update-default-config

    @cosmicBboy
    cosmicBboy authored Jan 10, 2023
    Configuration menu
    Copy the full SHA
    3f3c3d5 View commit details
    Browse the repository at this point in the history

  2. pr into #1384 (#1407) 

    Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Adds a test for false SSL for the old .ini style of config
Adds a shortcut for the pyflyte run/register commands - if no files are detected at all, create for sandbox instead. I think this is okay. The other option would be to fall back to checking the ~/.flyte/config-sandbox.yml file but I think using the code option is a bit cleaner, even though it ties us closer to the flytectl demo port settings.
    @wild-endeavor
    wild-endeavor authored Jan 10, 2023
    Configuration menu
    Copy the full SHA
    bfdefd3 View commit details
    Browse the repository at this point in the history

  3. fix lint 

    Signed-off-by: Niels Bantilan <niels.bantilan@gmail.com>
    @cosmicBboy
    cosmicBboy authored Jan 10, 2023
    Configuration menu
    Copy the full SHA
    768b423 View commit details
    Browse the repository at this point in the history