Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(auth): add audience for auth #1403

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

feat(auth): add audience for auth #1403

wants to merge 1 commit into from

Conversation

joatkh
Copy link

@joatkh joatkh commented Jan 5, 2023

TL;DR

Please replace this text with a description of what this PR accomplishes.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

Added audience to flytekit based on flyteidl release depending of this PR

@welcome
Copy link

welcome bot commented Jan 5, 2023

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

@akode
Copy link

akode commented Mar 14, 2023

Hi @joatkh ,
Thank you for this contribution.
Could you please sign-off your commits, so this PR can progress?

@kumare3
Copy link
Contributor

kumare3 commented Mar 29, 2023

@joatkh @akode I have infact merged Device authflow and audience support. Please check if that solves your problems. then we can close this PR. Merged PR #1552

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wild-endeavor wild-endeavor Awaiting requested review from wild-endeavor wild-endeavor will be requested when the pull request is marked ready for review wild-endeavor is a code owner

@kumare3 kumare3 Awaiting requested review from kumare3 kumare3 will be requested when the pull request is marked ready for review kumare3 is a code owner

@eapolinario eapolinario Awaiting requested review from eapolinario eapolinario will be requested when the pull request is marked ready for review eapolinario is a code owner

@pingsutw pingsutw Awaiting requested review from pingsutw pingsutw will be requested when the pull request is marked ready for review pingsutw is a code owner

@cosmicBboy cosmicBboy Awaiting requested review from cosmicBboy cosmicBboy will be requested when the pull request is marked ready for review cosmicBboy is a code owner

@samhita-alla samhita-alla Awaiting requested review from samhita-alla samhita-alla will be requested when the pull request is marked ready for review samhita-alla is a code owner

@thomasjpfan thomasjpfan Awaiting requested review from thomasjpfan thomasjpfan will be requested when the pull request is marked ready for review thomasjpfan is a code owner

@Future-Outlier Future-Outlier Awaiting requested review from Future-Outlier Future-Outlier will be requested when the pull request is marked ready for review Future-Outlier is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joatkh @akode @kumare3