MAINT Removes GitPython dependency #1966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
thomasjpfan
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw and
cosmicBboy
as code owners
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1966 +/- ##
==========================================
- Coverage 62.67% 62.55% -0.12%
==========================================
Files 313 313
Lines 23193 23247 +54
Branches 3514 3523 +9
==========================================
+ Hits 14537 14543 +6
- Misses 8234 8283 +49
+ Partials 422 421 -1 ☔ View full report in Codecov by Sentry. |
thomasjpfan
commented
Nov 16, 2023
| from git import Repo | ||
| git_config = source_path / ".git" / "config" | ||
| if not git_config.exists(): | ||
| raise ValueError(f"{source_path} is not a git repo") |
There was a problem hiding this comment.
I added tests to check these code paths. It's strange that codecov is not picking it up.
eapolinario
previously approved these changes
Nov 16, 2023
| elif url.startswith("https://"): | ||
| prefix_len = len("https://") | ||
| return url[prefix_len:] | ||
| else: |
There was a problem hiding this comment.
should we throw in support for http also?
|
just to expand on my previous comment, here are the tests for url parsing in git itself: https://github.com/git/git/blob/77bd3ea9f54f1584147b594abc04c26ca516d987/t/t0110-urlmatch-normalization.sh. Parsing urls is itself a can of worms. Having basic support for ssh + https/http covers more than the 90% of the cases. We can always expand later if necessary. |
Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
eapolinario
approved these changes
Nov 17, 2023
ringohoffman
pushed a commit
to ringohoffman/flytekit
that referenced
this pull request
Nov 24, 2023
* MAINT Removes GitPython dependency Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * MAINT Remove GitPython from requirements Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * STY Run linter Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * ENH Adds support for http Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> --------- Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
mark-thm
pushed a commit
to mark-thm/flytekit
that referenced
this pull request
Dec 8, 2023
* MAINT Removes GitPython dependency Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * MAINT Remove GitPython from requirements Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * STY Run linter Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * ENH Adds support for http Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> --------- Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com>
RRap0so
pushed a commit
to RRap0so/flytekit
that referenced
this pull request
Dec 15, 2023
* MAINT Removes GitPython dependency Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * MAINT Remove GitPython from requirements Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * STY Run linter Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> * ENH Adds support for http Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> --------- Signed-off-by: Thomas J. Fan <thomasjpfan@gmail.com> Signed-off-by: Rafael Raposo <rafaelraposo@spotify.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes GitPython dependency and adds more unit tests to check the updated function.
Type
Are all requirements met?
Complete description
GitPythonwas only used to read the remote url. This configuration is located in.git/config, which we can parse directly.Tracking Issue
Towards flyteorg/flyte#4418