Fix race conditions in the Authentication client #2635
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2626
Why are the changes needed?
The AuthorizationClient may need to pop up a webbrowser for human interaction to auth, and may do so from multiple threads and multiple grpcio channels. This manifested for us in race conditions during
pyflyte register
because it uses concurrent registrationflytekit/flytekit/tools/repo.py
Lines 310 to 311 in 1cc2b11
What changes were proposed in this pull request?
We block all threads and allow a single request through for authorization and cache that result for a short window to make sure that we don't need a separate request per-thread, and avoid the race condition on setting up the local HTTP server for handling the redirect.
How was this patch tested?
Lots of calls to pyflyte register in a repository with a large number of workflows.
Check all the applicable boxes