-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation notice for pod plugin #2698
Conversation
Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2698 +/- ##
==========================================
+ Coverage 78.91% 78.95% +0.03%
==========================================
Files 316 187 -129
Lines 24965 19232 -5733
Branches 4012 4017 +5
==========================================
- Hits 19702 15184 -4518
+ Misses 4548 3350 -1198
+ Partials 715 698 -17 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was always confused about the difference between this plugin and PodTemplate
. (I always just used PodTemplates
)
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Why are the changes needed?
The pod plugin functionality has been in the core task code for a while now. Users no longer need this plugin.
What changes were proposed in this pull request?
Add a deprecation notice to the init file and readme.
How was this patch tested?
Setup process
Screenshots
Check all the applicable boxes
Related PRs
Docs link