Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation notice for pod plugin #2698

Merged
merged 5 commits into from
Aug 21, 2024
Merged

Conversation

wild-endeavor
Copy link
Contributor

@wild-endeavor wild-endeavor commented Aug 21, 2024

Why are the changes needed?

The pod plugin functionality has been in the core task code for a while now. Users no longer need this plugin.

What changes were proposed in this pull request?

Add a deprecation notice to the init file and readme.

How was this patch tested?

Setup process

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Docs link

Signed-off-by: Yee Hing Tong <wild-endeavor@users.noreply.github.com>
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.95%. Comparing base (a8f68d7) to head (21501b7).
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2698      +/-   ##
==========================================
+ Coverage   78.91%   78.95%   +0.03%     
==========================================
  Files         316      187     -129     
  Lines       24965    19232    -5733     
  Branches     4012     4017       +5     
==========================================
- Hits        19702    15184    -4518     
+ Misses       4548     3350    -1198     
+ Partials      715      698      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Copy link
Member

@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was always confused about the difference between this plugin and PodTemplate. (I always just used PodTemplates)

plugins/flytekit-k8s-pod/README.md Outdated Show resolved Hide resolved
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Signed-off-by: Eduardo Apolinario <eapolinario@users.noreply.github.com>
Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@wild-endeavor wild-endeavor merged commit 184bce7 into master Aug 21, 2024
97 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants