Fix local test test_get_config_file
fail
#2705
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
flyteorg/flyte#5687
Why are the changes needed?
The
get_config_file
will check some default paths if the function's input isNone
, while the assert function in the unit test didn't consider it. This will not throw errors in Github actions since it is building a clean environment, but when developers test it locally, it often throws errors.What changes were proposed in this pull request?
Check the path in the unit-test.
How was this patch tested?
Setup process
Run it locally
Screenshots
I'll open another PR to fix the other 2 unit tests.
Check all the applicable boxes
Related PRs
#2706
#2707
Docs link