Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix local test test_get_config_file fail #2705

Merged
merged 3 commits into from
Aug 23, 2024

Conversation

Mecoli1219
Copy link
Contributor

@Mecoli1219 Mecoli1219 commented Aug 23, 2024

Tracking issue

flyteorg/flyte#5687

Why are the changes needed?

The get_config_file will check some default paths if the function's input is None, while the assert function in the unit test didn't consider it. This will not throw errors in Github actions since it is building a clean environment, but when developers test it locally, it often throws errors.

What changes were proposed in this pull request?

Check the path in the unit-test.

How was this patch tested?

make unit_test

Setup process

Run it locally

Screenshots

I'll open another PR to fix the other 2 unit tests.
image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

#2706
#2707

Docs link

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 50.37%. Comparing base (a8f68d7) to head (1072bc9).
Report is 9 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (a8f68d7) and HEAD (1072bc9). Click for more details.

HEAD has 10 uploads less than BASE
Flag BASE (a8f68d7) HEAD (1072bc9)
32 22
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2705       +/-   ##
===========================================
- Coverage   78.91%   50.37%   -28.55%     
===========================================
  Files         316      280       -36     
  Lines       24965    23507     -1458     
  Branches     4012     4017        +5     
===========================================
- Hits        19702    11842     -7860     
- Misses       4548    11537     +6989     
+ Partials      715      128      -587     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Mecoli1219 and others added 3 commits August 23, 2024 15:34
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Co-authored-by: Kevin Su <pingsutw@gmail.com>
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
Signed-off-by: Mecoli1219 <michaellai901026@gmail.com>
@pingsutw pingsutw merged commit 94148df into flyteorg:master Aug 23, 2024
98 of 99 checks passed
@Mecoli1219 Mecoli1219 deleted the fix_test_get_config_file branch August 24, 2024 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants