Revert #2303 #2746
Merged
Revert #2303 #2746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
requested review from
wild-endeavor,
kumare3,
eapolinario,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
|
I don't think I was involved in the original PR here and this code doesn't look too familiar -- not sure I have much to offer. I think this one was @thomasjpfan |
|
Sorry, I ping you at the wrong PR. I was trying to ping you at flyteorg/flyte#5740 |
wild-endeavor
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
#2303 (comment)
Why are the changes needed?
This change is leading to some weird behavior and I think part of it is working by coincidence. We noticed this because of a test that was failing in Pycharm but passing in CI. But you can reproduce a similar error just with pytest.
Cannot submit a task from the notebook after this commit
What changes were proposed in this pull request?
Revert some of the changes in #2303
How was this patch tested?
unit test
Setup process
Screenshots
Check all the applicable boxes
Related PRs
NA
Docs link
NA