Support FlyteRemote.execute interruptible flag override
#2885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: redartera <reda@artera.ai>
Signed-off-by: redartera <reda@artera.ai>
Signed-off-by: redartera <reda@artera.ai>
redartera
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
Signed-off-by: redartera <reda@artera.ai>
Signed-off-by: redartera <reda@artera.ai>
pingsutw
approved these changes
Nov 4, 2024
|
@pingsutw Can we please merge this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte#5279
Why are the changes needed?
It is useful for users to invoke the same
LaunchPlanbut overriding at runtime whether they need executions to be interruptible or not. Currently this is possible through the Flyte UI, but notflytekit.What changes were proposed in this pull request?
Support an
interruptibleoption inFlyteRemote.executeHow was this patch tested?
Integration test added
Check all the applicable boxes