This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Deck apis #272
Merged
Deck apis #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Codecov Report
@@ Coverage Diff @@
## master #272 +/- ##
==========================================
- Coverage 63.01% 62.97% -0.04%
==========================================
Files 142 142
Lines 8968 8970 +2
==========================================
- Hits 5651 5649 -2
- Misses 2796 2799 +3
- Partials 521 522 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hamersaw
approved these changes
Jun 22, 2022
pingsutw
approved these changes
Jun 22, 2022
eapolinario
pushed a commit
that referenced
this pull request
Sep 6, 2023
* Generate Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update OutputReader interface for Decks Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Fix tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Modifies the Deck APIs to keep them consistent with the enclosing interfaces. Since these APIs are internal and unused, I think it's ok to not bump minor versions.
Type
Are all requirements met?
Tracking Issue
flyteorg/flyte#2175