-
Notifications
You must be signed in to change notification settings - Fork 53
[Bigquery] Add support for impersonation of GSA bound to task's KSA #355
Conversation
go/tasks/pluginmachinery/google/gke_task_workload_identity_token_source_factory.go
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #355 +/- ##
==========================================
+ Coverage 62.80% 63.89% +1.08%
==========================================
Files 148 152 +4
Lines 12701 10355 -2346
==========================================
- Hits 7977 6616 -1361
+ Misses 4112 3126 -986
- Partials 612 613 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
9ba699c
to
1cd1e05
Compare
…uery plugin Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
1cd1e05
to
21c1187
Compare
Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks pretty reasonable to me. We should make sure we update the docs to call out this new gke-task-workload-identity
token source. We should be sure to mention that the KSA that (I think...) flytepropeller
uses must have enough permissions to read ServiceAccount objects from the k8s API.
And also that the GSA bound to Flytepropeller's KSA must be able to impersonate GSAs bound to the respective task KSAs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome.
…355) * Support impersonation of GKE task workload identity bound GSA in BigQuery plugin Signed-off-by: Jeev B <jeevb@users.noreply.github.com> * Fix linting Signed-off-by: Jeev B <jeevb@users.noreply.github.com> --------- Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
Addresses: flyteorg/flyte#3736
Incorporates lost changes from #161 with some some modern bits.
Smoke tested on GCP test cluster with flytesnacks BQ workflow. In the second snapshot, the correct GSA,
userflyterole
, is used.