This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
When the
dask
plugin creates aDaskJob
k8s resource, it will initially not have the.Status.JobStatus
property set.So
flyteplugins/go/tasks/plugins/k8s/dask/dask.go
Line 316 in de1d1d3
will return an empty string until the
DaskOperator
sets the status for the first time. While this period is very brief, we've seen it happening a few times.This PR adds support for the
""
state, effectively handling it the same as being queued/initializing.Type
Are all requirements met?