This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
Add deck_uri to NodeExecutionEvent #443
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Su <pingsutw@apache.org>
pingsutw
changed the title
Add deck_uri in NodeExecutionEvent
Add deck_uri to NodeExecutionEvent
May 24, 2022
Signed-off-by: Kevin Su <pingsutw@apache.org>
EngHabu
reviewed
Jun 1, 2022
8 tasks
Signed-off-by: Kevin Su <pingsutw@apache.org>
EngHabu
reviewed
Jun 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @pingsutw I think this is close!
Signed-off-by: Kevin Su <pingsutw@apache.org>
Few updates, cc @EngHabu
|
2 tasks
Signed-off-by: Kevin Su <pingsutw@apache.org>
EngHabu
reviewed
Jun 9, 2022
cc @EngHabu |
One small question. I've tried to shy away from adding more to the NodeStatus on the NodeExecutionContext because it "claims" to be deprecated from the NodeExecutionContext. If this is the case we may want to find a better location for the deckURI; otherwise, it may be nice to remove the deprecated comment. |
I think it's ok to remove NodeStatus. IIUC, we will replace NodeStatus with OutputWriter. if so, we can use OutputWriter.GetDeckPath() to get |
Fixed it #453 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Su pingsutw@apache.org
TL;DR
Add deck_uri in NodeExecutionEvent
Type
Are all requirements met?
Complete description
How did you fix the bug, make the feature etc. Link to any design docs etc
Tracking Issue
flyteorg/flyte#2175
fixes https://github.com/flyteorg/flyte/issues/
Follow-up issue
NA