Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Add deck_uri to NodeExecutionEvent #443

Closed
wants to merge 24 commits into from
Closed

Add deck_uri to NodeExecutionEvent #443

wants to merge 24 commits into from

Conversation

pingsutw
Copy link
Member

Signed-off-by: Kevin Su pingsutw@apache.org

TL;DR

Add deck_uri in NodeExecutionEvent

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

How did you fix the bug, make the feature etc. Link to any design docs etc

Tracking Issue

flyteorg/flyte#2175

fixes https://github.com/flyteorg/flyte/issues/

Follow-up issue

NA

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #443 (443785f) into master (d5ba4c7) will increase coverage by 0.03%.
The diff coverage is 75.00%.

Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw changed the title Add deck_uri in NodeExecutionEvent Add deck_uri to NodeExecutionEvent May 24, 2022
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw
Copy link
Member Author

pingsutw commented Jun 1, 2022

cc @kumare3 @EngHabu

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw marked this pull request as draft June 6, 2022 16:30
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw marked this pull request as ready for review June 6, 2022 17:05
@pingsutw pingsutw requested a review from EngHabu June 7, 2022 16:21
Signed-off-by: Kevin Su <pingsutw@apache.org>
Copy link
Contributor

@EngHabu EngHabu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @pingsutw I think this is close!

go.mod Outdated Show resolved Hide resolved
pkg/controller/nodes/task/handler.go Outdated Show resolved Hide resolved
pkg/controller/nodes/transformers.go Outdated Show resolved Hide resolved
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw
Copy link
Member Author

pingsutw commented Jun 7, 2022

Few updates, cc @EngHabu

  • Upgraded flyteplugin
  • Drop the changes in datacatalog (will create a new issue for caching deck)
  • Add deck_uri in outputInfo

Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
Signed-off-by: Kevin Su <pingsutw@apache.org>
@pingsutw pingsutw requested a review from EngHabu June 11, 2022 06:02
@pingsutw
Copy link
Member Author

cc @EngHabu

@hamersaw
Copy link
Contributor

One small question. I've tried to shy away from adding more to the NodeStatus on the NodeExecutionContext because it "claims" to be deprecated from the NodeExecutionContext. If this is the case we may want to find a better location for the deckURI; otherwise, it may be nice to remove the deprecated comment.

@pingsutw
Copy link
Member Author

I think it's ok to remove NodeStatus. IIUC, we will replace NodeStatus with OutputWriter. if so, we can use OutputWriter.GetDeckPath() to get deck_uri.

@EngHabu EngHabu mentioned this pull request Jun 21, 2022
8 tasks
@pingsutw
Copy link
Member Author

Fixed it #453

@pingsutw pingsutw closed this Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants