This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Tracking terminated workflows in LRU cache #450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
Signed-off-by: Daniel Rammer <daniel@union.ai>
ckiosidis
reviewed
Aug 22, 2022
EngHabu
approved these changes
Aug 30, 2022
2 tasks
9 tasks
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* added lru filter to track terminated workflows Signed-off-by: Daniel Rammer <daniel@union.ai> * updated unit tests Signed-off-by: Daniel Rammer <daniel@union.ai> * add test on terminated filter Signed-off-by: Daniel Rammer <daniel@union.ai> Signed-off-by: Daniel Rammer <daniel@union.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
Adding a LRU filter cache to the resource version caching workflow store. We add the workflow resource version key if the workflow is successfully updated to a terminal phase. When workflows are requested with "get" we first lookup to see if the workflow has already been terminated. This fixes issues where we attempt to process a workflow that has already reached the terminal state, since the system is eventually consistent this may happen frequently.
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
fixes flyteorg/flyte#2546
Follow-up issue
NA