This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Use fnv64 to create a hash for child workflow executions #476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
hamersaw
approved these changes
Sep 9, 2022
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
* Prefix sub-lp exec id with the parent exec-id Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * cleanup Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * cleanup Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Use a CRD-level version instead Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * cleanup Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Use fnv64 to create a hash for child workflow executions Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Move DefinitionVersion to Status of the CRD Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Update to the released flyteplugins Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * Regenerate Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * fix unit tests Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * more fixes Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> * fix old unit test Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com> Signed-off-by: Haytham Abuelfutuh <haytham@afutuh.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Haytham Abuelfutuh haytham@afutuh.com
TL;DR
Use fnv64-bit for new child workflow execution names to decrease the probability of name collisions.
Ensure backward compatibility by storing a version in the workflow CRD to be able to generate the same id for check status as we did for launch.
Type
Are all requirements met?
Remaining work
Tracking Issue
fixes flyteorg/flyte#2778