This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Reverting to parallelism increases only on non-terminal phase updates #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Rammer <daniel@union.ai>
pingsutw
approved these changes
Sep 29, 2023
Signed-off-by: Daniel Rammer <daniel@union.ai>
Codecov Report
Additional details and impacted files |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
These two (1 and 2) changes attempted to fix parallelism computations. However, they introduced additional issues where now if a node in the DAG is visited multiple times in the same round it may count each time towards the parallelism. This PR reverts to previous parallelism computation (which may still be incorrect in certain scenarios).
Type
Are all requirements met?
Complete description
^^^
Tracking Issue
NA
Follow-up issue
NA