This repository has been archived by the owner on Oct 9, 2023. It is now read-only.
Bug/Feature: Dynamic parent node should be finalized earlier #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This will enable Dynamic node to be released and allow termination as soon as it is complete
Codecov Report
@@ Coverage Diff @@
## master #94 +/- ##
==========================================
+ Coverage 49.71% 49.77% +0.05%
==========================================
Files 127 127
Lines 7939 7948 +9
==========================================
+ Hits 3947 3956 +9
Misses 3608 3608
Partials 384 384
Continue to review full report at Codecov.
|
|
looks good. |
EngHabu
previously approved these changes
Mar 19, 2020
| @@ -129,6 +129,8 @@ func (d dynamicNodeTaskNodeHandler) handleDynamicSubNodes(ctx context.Context, n | |||
| return trns, newState, nil | |||
| } | |||
|
|
|||
| // The State machine for a dynamic node is as follows | |||
There was a problem hiding this comment.
Did you mean to complete this paragraph ?
There was a problem hiding this comment.
ohh ya, fragmented brain! Done
anandswaminathan
approved these changes
Mar 24, 2020
kumare3
pushed a commit
to nuclyde-io/flytepropeller
that referenced
this pull request
Feb 4, 2021
eapolinario
pushed a commit
to eapolinario/flytepropeller
that referenced
this pull request
Aug 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TL;DR
This is not really a bug, but it so happens that the Parent node is stuck in terminating until the entire dynamic node is finalized. Which may take hours depending on the subnodes. This fix enable s Dynamic node to be released and allow termination as soon as it is complete
Type
Are all requirements met?
Complete description
Dynamic node now has an intermediate state that especially handles finalization of the parent node
Tracking Issue
flyteorg/flyte#209
Follow-up issue
NA