Publish multi-architecture images #70
Conversation
jeevb
force-pushed
the
jeev/multiarch-builds
branch
from
1ca3116
to
36c74e5
Compare
Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
jeevb
force-pushed
the
jeev/multiarch-builds
branch
from
61f116d
to
2f2b300
Compare
|
Tested against flyteconsole so far. |
Signed-off-by: Jeev B <jeevb@users.noreply.github.com>
| @@ -30,6 +30,13 @@ jobs: | |||
| - name: Prime docker cache | |||
| run: (docker load -i /tmp/tmp/docker-images/snapshot-builder.tar || true) && (docker load -i /tmp/tmp/docker-images/snapshot.tar || true) | |||
| - name: Build dockerfile | |||
There was a problem hiding this comment.
This pipeline is currently being used by flyteadmin, flytepropeller, and datacatalog to build images for e2e tests. AFAICT, these images are not pushed to any registry. Can someone confirm?
Eventually, we might consider running tests on all supported architectures, but this might be currently too slow on GHA runners with emulation. We can leave this as-is for now, and only build amd64 images for testing purposes.
There was a problem hiding this comment.
i don't think these are pushed, i can't actually tell why this step is necessary, all three of these have a separate push step after.
There was a problem hiding this comment.
Some of the abovementioned repos use them for e2e tests.
Addresses: flyteorg/flyte#2935