fix(fleet): fix ability to delete a maanged fleet

Signed-off-by: Thierry Bugier <tbugier@teclib.com>
flyve-mdm · Apr 2, 2018 · ff6111b · ff6111b
1 parent b7501de
commit ff6111b
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/inc/fleet.class.php b/inc/fleet.class.php
@@ -102,6 +102,13 @@ public function defineTabs($options = []) {
       return $tab;
    }
 
+   function canPurgeItem() {
+      if ($this->fields['is_default'] == '1') {
+         return false;
+      }
+      return parent::checkEntity();
+   }
+
    /**
     * Show form for edition
     * @param $ID
@@ -461,8 +468,8 @@ public function getFromDBByDefaultForEntity($entityId = null) {
     * @param string $entityId ID of the entoty to search in
     * @return PluginFlyvemdmFleet|null
     */
-   public static function getDefaultFleet($entityId = '') {
-      if ($entityId == '') {
+   public static function getDefaultFleet($entityId = null) {
+      if ($entityId === null) {
          $entityId = $_SESSION['glpiactive_entity'];
       }
       $defaultFleet = new PluginFlyvemdmFleet();

diff --git a/tests/suite-unit/PluginFlyvemdmFleet.php b/tests/suite-unit/PluginFlyvemdmFleet.php
@@ -97,6 +97,13 @@ public function testGetMenuPicture() {
       $this->given($class)->string($class::getMenuPicture())->isEqualTo('fa-group');
    }
 
+   public function testPurgeteItem() {
+      $instance = \PluginFlyvemdmFleet::getDefaultFleet(0);
+      $this->variable($instance)->isNotNull();
+      $_SESSION['glpiactiveentities'] = [0];
+      $this->boolean($instance->canPurgeItem())->isFalse();
+   }
+
    /**
     * @tags testShowForm
     */