Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poetry and linting #25

Merged
merged 6 commits into from
Sep 12, 2023
Merged

Poetry and linting #25

merged 6 commits into from
Sep 12, 2023

Conversation

gardenerik
Copy link
Member

@gardenerik gardenerik commented Sep 11, 2023 •
edited
Loading

Closes #17, closes #7

@mrshu
Copy link
Contributor

mrshu commented Sep 12, 2023

I am honestly not really sure why did the test-code workflow fail (that requirements.txt does exist), but the fact that it uses Python 3.8 probably does not help.

@gardenerik
Copy link
Member Author

Maybe we should just remove it, as there does not seem to be a single passing commit 😅
https://github.com/fmfi-svt/candle-ng/actions/workflows/test.yml

@gardenerik gardenerik merged commit 76a728c into master Sep 12, 2023
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrshu mrshu mrshu approved these changes

@Adman Adman Awaiting requested review from Adman

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add black, flake8, isort into workflow Code style: avoid using backslash
2 participants
@gardenerik @mrshu