-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* Implement styled arguments * Inherit from formatter<Arg> to get the underlying `parse` and `format` * Move styled_arg definition into the previous detail block * Change styled_arg ctor parameters names to avoid shadowing members * Move const before auto * Remove redundant constructor for styled_arg * Use the iterator instead of the buffer in styled_arg::format * Remove unnecessary `styled` overloads * Remove defaulted text_style parameter in styled function
- Loading branch information
Showing
2 changed files
with
64 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8c9bc07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The format specifier
{s:.2f}
of this example doesn't work, see https://godbolt.org/z/G8n6WWT6x, should there maybe be{0:.2f}
like in the other examples?8c9bc07
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ssbssa, good catch, thanks! Fixed in 6452e3c.