Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(patch) unit test portability improvements #179

Closed
jackyf opened this issue Jun 20, 2015 · 2 comments
Closed

(patch) unit test portability improvements #179

jackyf opened this issue Jun 20, 2015 · 2 comments

Comments

@vitaut
Copy link
Contributor

vitaut commented Jun 22, 2015

@jackyf Thanks for the patches. Regarding the last one, I think POSIX allows this:

pipe:

A process has the pipe open for reading (correspondingly writing) if it has a file descriptor open that refers to the read end, fildes[0] (write end, fildes[1]).

read:

[EBADF]
The fildes argument is not a valid file descriptor open for reading.

Does it cause a test failure on some platform?

@vitaut
Copy link
Contributor

vitaut commented Jun 23, 2015

My bad, I see you mention this in the commit message:

Those unit tests actually fail on kfreebsd-* architectures: ReadError hangs and WriteError throws.

vitaut added a commit that referenced this issue Jun 25, 2015
@vitaut vitaut closed this as completed Jun 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants