Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

trunk doesn't work with std::generator #4053

Closed
hewillk opened this issue Jul 6, 2024 · 1 comment · Fixed by #4057
Closed

trunk doesn't work with std::generator #4053

hewillk opened this issue Jul 6, 2024 · 1 comment · Fixed by #4057

Comments

@hewillk
Copy link

hewillk commented Jul 6, 2024

#include <fmt/ranges.h>
#include <sstream>
#include <generator>

std::generator<std::string&> istream_gen() {
  auto words = std::istringstream{"today is yesterday's tomorrow"};
  std::string word;
  while (words >> word)
    co_yield word;
}

int main() {
  fmt::print("{}\n", istream_gen());
}

https://godbolt.org/z/s7sGrGvzd

@vitaut
Copy link
Contributor

vitaut commented Jul 6, 2024

Looks like move is missing somewhere.

Arghnews added a commit to Arghnews/fmt that referenced this issue Jul 7, 2024
Arghnews added a commit to Arghnews/fmt that referenced this issue Jul 8, 2024
@vitaut vitaut closed this as completed in e60ff50 Jul 9, 2024
mtremer pushed a commit to ipfire/ipfire-2.x that referenced this issue Aug 15, 2024
- Update from version 11.0.1 to 11.0.2
- Update of rootfile
- Changelog
    11.0.2
	- Fixed compatibility with non-POSIX systems
	  (fmtlib/fmt#4054,
	  fmtlib/fmt#4060).
	- Fixed performance regressions when using `std::back_insert_iterator` with
	  `fmt::format_to` (fmtlib/fmt#4070).
	- Fixed handling of `std::generator` and move-only iterators
	  (fmtlib/fmt#4053,
	  fmtlib/fmt#4057). Thanks @Arghnews.
	- Made `formatter<std::string_view>::parse` work with types convertible to
	  `std::string_view` (fmtlib/fmt#4036,
	  fmtlib/fmt#4055). Thanks @Arghnews.
	- Made `volatile void*` formattable
	  (fmtlib/fmt#4049,
	  fmtlib/fmt#4056). Thanks @Arghnews.
	- Made `Glib::ustring` not be confused with `std::string`
	  (fmtlib/fmt#4052).
	- Made `fmt::context` iterator compatible with STL algorithms that rely on
	  iterator category (fmtlib/fmt#4079).

Signed-off-by: Adolf Belka <adolf.belka@ipfire.org>
Signed-off-by: Michael Tremer <michael.tremer@ipfire.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants