Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable warning about format string #2067

Merged
merged 1 commit into from Dec 21, 2020
Merged

Disable warning about format string #2067

merged 1 commit into from Dec 21, 2020

Conversation

HazardyKnusperkeks
Copy link
Contributor

Reported by MinGW/GCC 10

I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.

Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

It's better to suppress the warning in the same way it is done for printf

int (*snprintf_ptr)(char*, size_t, const char*, ...) = FMT_SNPRINTF;
instead of using compiler-specific #pragma warning.

Reported by MinGW/GCC 10
@HazardyKnusperkeks
Copy link
Contributor Author

Updated.

And for the record, the internal compiler error (which forbids auto) seems to be still in place with GCC/MinGW 10.2.

@vitaut vitaut merged commit 5a37e18 into fmtlib:master Dec 21, 2020
@vitaut
Copy link
Contributor

vitaut commented Dec 21, 2020

Thanks

@HazardyKnusperkeks HazardyKnusperkeks deleted the suppress-warning branch December 21, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants