Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fmt::localtime formatting not working in wide-char string contexts #2128

Closed
wants to merge 1 commit into from
Closed

Conversation

yNeo
Copy link
Contributor

@yNeo yNeo commented Feb 7, 2021

Issue was caused by incorrectly using an explicit type for parse_context parameter instead of a templated type, which meant that the parse function would only work in regular string contexts.

I agree that my contributions are licensed under the {fmt} license, and agree to future changes to the licensing.

@vitaut
Copy link
Contributor

vitaut commented Feb 7, 2021

Thanks. LGTM but could you add a test case in https://github.com/fmtlib/fmt/blob/master/test/chrono-test.cc?

@vitaut
Copy link
Contributor

vitaut commented Feb 13, 2021

Added a test and merged in c5979d5.

@vitaut vitaut closed this Feb 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants