Use simplified void_t for all compilers except GCC 4.x #2160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2149.
This PR moves a special
void_t
workaround for GCC 4.x:fmt/include/fmt/core.h
Lines 1382 to 1385 in 640acba
under the GCC < 5.0 macro check, adding a straightforward
void_t
implementation:for other compilers.
This solves the problem with GCC 8.x that fails with the current implementation of
void_t
.