Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unneeded num_result_bigits decrement #2398

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Remove unneeded num_result_bigits decrement #2398

merged 1 commit into from
Jun 29, 2021

Conversation

javierhonduco
Copy link
Contributor

For what I see this seems unused?

@javierhonduco
Remove unneeded num_result_bigits decrement
3628a80 
For what I see this seems unused?
@vitaut vitaut marked this pull request as ready for review June 29, 2021 13:22
@vitaut vitaut merged commit 002bb75 into fmtlib:master Jun 29, 2021
@vitaut
Copy link
Contributor

vitaut commented Jun 29, 2021

Good catch, thanks.

@javierhonduco javierhonduco deleted the patch-3 branch June 29, 2021 14:28
@javierhonduco
Copy link
Contributor Author

Thanks @vitaut! Found this internally running infer in our fbcode project cc @jvillard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@javierhonduco @vitaut