Fix access mode of files created (#2530) #2733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix for this in 4a85db1 was incomplete. The intent was to mimic what `fopen()` is doing. As per standard[1] `fopen()` also sets `S_IWGRP` and `S_IWOTH` and lets the umask handle the rest. [1] https://pubs.opengroup.org/onlinepubs/9699919799.2018edition/functions/fopen.html
|
Do we need automated test for that and if so: how would you like it implemented? |
|
Thanks for the PR! A test would be nice, please add one to https://github.com/fmtlib/fmt/blob/master/test/os-test.cc (it can be POSIX-specific/disabled on Windows for simplicity). |
|
Anyway, this is a straightforward fix so I'm merging this in but a PR with a test would be welcome. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix for this in 4a85db1 was incomplete. The intent was to
mimic what
fopen()is doing. As per standard[1]fopen()also setsS_IWGRPandS_IWOTHand lets the umask handle the rest.[1] https://pubs.opengroup.org/onlinepubs/9699919799.2018edition/functions/fopen.html