-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Constexpr formatted_size #3026
Merged
Merged
Constexpr formatted_size #3026
Changes from 9 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1f0c91e
Constexpr formatted_size
marksantaniello 4767e72
Constexpr formatted_size
marksantaniello 4c43885
Merge branch 'master' of https://github.com/marksantaniello/fmt
marksantaniello 437f7c4
Merge branch 'master' of https://github.com/marksantaniello/fmt
marksantaniello 78381a8
Merge branch 'master' of https://github.com/marksantaniello/fmt
marksantaniello 4a8a038
Merge branch 'fmtlib:master' into master
marksantaniello 39c52e4
Add C++20 tests for gcc 9 and 10
marksantaniello 003ccb4
Adjust unit test to require __cpp_lib_bit_cast
marksantaniello b519f0c
Merge branch 'master' of https://github.com/marksantaniello/fmt
marksantaniello a703799
Address feedback from Victor
marksantaniello 303489a
Merge branch 'fmtlib:master' into master
marksantaniello File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -228,8 +228,16 @@ TEST(compile_test, format_to_n) { | |
} | ||
|
||
TEST(compile_test, formatted_size) { | ||
EXPECT_EQ(2, fmt::formatted_size(FMT_COMPILE("{0}"), 42)); | ||
EXPECT_EQ(5, fmt::formatted_size(FMT_COMPILE("{0:<4.2f}"), 42.0)); | ||
#ifdef __cpp_lib_bit_cast | ||
FMT_CONSTEXPR20 | ||
#endif | ||
size_t s1 = fmt::formatted_size(FMT_COMPILE("{0}"), 42); | ||
EXPECT_EQ(2, s1); | ||
#ifdef __cpp_lib_bit_cast | ||
FMT_CONSTEXPR20 | ||
#endif | ||
size_t s2 = fmt::formatted_size(FMT_COMPILE("{0:<4.2f}"), 42.0); | ||
EXPECT_EQ(5, s2); | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Let's conditionally compile the test case itself because the whole purpose of it is to test constexpr formatted_size. Also formatted_size -> contexpr_formatted_size to make it clear what we are testing here.
|
||
|
||
TEST(compile_test, text_and_arg) { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As commented earlier, let's not add new CI configs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, yes -- I'm just crap at git. Will try again.