-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support formatting of time_point with utc_clock #3110
Conversation
edb0104
to
b512318
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Overall looks good, just a few nits inline.
Thanks for the review! Pushed the fixes. |
Looks good but there are some CI failures. |
The chrono test fails with
As this happens only for MSC version 1929 but not for version 1933 (the newest one), I check for this version now. |
It's probably not related to the MSVC version. Windows doesn't "historically" use the IANA time zone names, and so to support them for
|
@patrickroocks, @vitaut, Lines 153 to 156 in 48f525d
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe disable this test for Windows?
Fine with me.
Also if @mwinterb is correct then the current MSVC check will only mask the issue and should be removed.
bcfd937
to
806a939
Compare
Removed the MSVC check, disabled the |
Thank you! |
According to the discussion in #3098 in this PR a formatter for
std::chrono::time_point<std::chrono::utc_clock>
is added. Also added a small unit test. fmtlib must be compiled with C++20 or later to use this, asstd::chrono::utc_clock
is a C++20 feature.