Use void(*)(void*) instead of decltype(&std::free) to satisfy clang in CUDA mode
#3751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n CUDA mode clang can't resolve &std::free in decltype(&std::free) because std::free is overloaded (for host and device).
|
Thank you! |
happymonkey1
pushed a commit
to happymonkey1/fmt
that referenced
this pull request
Apr 7, 2024
…n CUDA mode (fmtlib#3751) clang can't resolve &std::free in decltype(&std::free) because std::free is overloaded (for host and device).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3740. It seems like clang is ok with
&std::freepassed as an argument to theunique_ptrconstructor (I think it's able to pick host/device overloads based on the function where it's used, but not insidedecltype), so that is intentionally left unchanged.