Don't always enable typeid usage under MSVC #3821
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FMT_USE_TYPEID
is always being enabled currently when building with MSVC, even if the comment says that typeid is always available with MSVC, it is not exactly correct. In fact, building the first example from herewith exeptions disabled, will fail with the c++ exeption
Access violation - no RTTI data!
when callingtypeid
on the first dereferenced pointer. Even if this is not an issue with the current only place where it is used in fmt (haven't actually tested it), it's better to just disable it and not risk an exception being thrown when formatting an exception (would be pretty ironic tho).