Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix chrono locale format bug for RHEL gcc #3859

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Fix chrono locale format bug for RHEL gcc #3859

merged 2 commits into from
Feb 25, 2024

Conversation

g199209
Copy link
Contributor

@g199209 g199209 commented Feb 20, 2024

Fix #3858

Gao Mingfei added 2 commits February 20, 2024 12:02
Fix chrono locale format bug for RHEL gcc
964f9a1 
Fix fmtlib#3858

Signed-off-by: Gao Mingfei <gaomingfei@mdsl-invest.com>
fix format
e9ea1b4
@phprus
Copy link
Contributor

phprus commented Feb 20, 2024

This is a bug in the devtoolset architecture.
devtoolset claims the features of the new libstdc++, but does not fully implement them.
Unfortunately, there is no easy way to determine whether devtoolset is being used.

We need to check your patch in SUSE Enterprise Linux 12 or in openSUSE Leap 42.3 (with forced activation of OLD and NEW ABI modes). Base compiler in SUSE 12 - gcc 4.8, and SUSE 12 provide new gcc (5,6,7) (with OLD and NEW ABI).

vitaut
vitaut requested changes Feb 24, 2024
View reviewed changes
Copy link
Contributor

@vitaut vitaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do additional testing per comment by @phprus.

@g199209
Copy link
Contributor Author

g199209 commented Feb 25, 2024

Please do additional testing per comment by @phprus.

I do not have such test enviroment.

@phprus
Copy link
Contributor

phprus commented Feb 25, 2024

@vitaut
I tested it.
Fix is ok.

@vitaut vitaut merged commit ebea573 into fmtlib:master Feb 25, 2024
41 checks passed
happymonkey1 pushed a commit to happymonkey1/fmt that referenced this pull request Apr 7, 2024
@g199209 @happymonkey1
Fix chrono locale format bug for RHEL gcc (fmtlib#3859)
1c9530a
@BrewTestBot BrewTestBot mentioned this pull request Jul 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vitaut vitaut vitaut approved these changes

@phprus phprus phprus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

chrono locale format code has some bug when using RHEL gcc on CentOS 7.6 to compile
3 participants
@g199209 @phprus @vitaut