Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSVC 17.10.0 + modules cannot find definition #3972

Merged
merged 1 commit into from
May 28, 2024

Conversation

matt77hias
Copy link
Contributor

@matt77hias matt77hias commented May 23, 2024

MSVC regressed since the new 17.10.0 compiler update. node<> cannot be found for detail::dynamic_arg_list::typed_node.

error C2504: 'fmt::v10::detail::dynamic_arg_list::node<void>': base class undefined

@matt77hias
Copy link
Contributor Author

I have not checked the non-modules path, but I assume you have CI coverage for that.

@vitaut
Copy link
Contributor

vitaut commented May 24, 2024

This looks like an MSVC bug. Could you report to Microsoft?

@vitaut
Copy link
Contributor

vitaut commented May 27, 2024

And once reported to Microsoft please add a link to that report here so that we knew when the issue is fixed.

@matt77hias
Copy link
Contributor Author

matt77hias commented May 28, 2024

MSDN: https://developercommunity.visualstudio.com/t/C-Modules-C2504-inner-base-class-undef/10668945?q=%5BFixed+In&scope=follow

Fyi I do not use dynamic_format_arg_store directly, but it seemed the easiest way to trigger the error.

MSVC regressed since the new 17.10.0 compiler update. node<> cannot be found for detail::dynamic_arg_list::typed_node.
@vitaut vitaut merged commit 43ab964 into fmtlib:master May 28, 2024
43 checks passed
@vitaut
Copy link
Contributor

vitaut commented May 28, 2024

Merged, thanks

@matt77hias matt77hias deleted the msvc-workaround branch May 29, 2024 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants