Concept-oriented checks for "row extraction" #1195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* "row extractor" methods must be const-qualified * Some unit tests for "row extraction" * Replaced two levels of indirection (row extractor builder and "mapped" row extractor) with the simpler `is_mapped` trait.
fnc12
approved these changes
Jul 19, 2023
fnc12
approved these changes
Jul 19, 2023
|
thanks @trueqbit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by #1193 this PR introduces concept-oriented checks at the point where a "row extractor" is used and whether it can be used for a certain purpose.
This essentially results in clear compiler error messages in case custom user-defined row extractors do the wrong thing.
Changes include:
is_mappedtrait.