-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yet another code quality PR #1337
Merged
Merged
Commits on Jul 17, 2024
-
Added includes of dependent headers
* Added missing includes of dependent internal headers * Cleaned up amalgamation files to only include the public facing high-level headers
Configuration menu - View commit details
-
Copy full SHA for 26c0b76 - Browse repository at this point
Copy the full SHA 26c0b76View commit details -
Configuration menu - View commit details
-
Copy full SHA for 69b2389 - Browse repository at this point
Copy the full SHA 69b2389View commit details
Commits on Jul 18, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b81b407 - Browse repository at this point
Copy the full SHA b81b407View commit details -
* last insert rowid * With insert * moved "With select" to storage_tests.cpp
Configuration menu - View commit details
-
Copy full SHA for c4f3770 - Browse repository at this point
Copy the full SHA c4f3770View commit details
Commits on Jul 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for b66c348 - Browse repository at this point
Copy the full SHA b66c348View commit details -
Included <sqlite3.h> explicitly in examples and unit tests
When importing sqlite_orm as a named module, sqlite3 symbols are not exported.
Configuration menu - View commit details
-
Copy full SHA for d639111 - Browse repository at this point
Copy the full SHA d639111View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6a96d1c - Browse repository at this point
Copy the full SHA 6a96d1cView commit details
Commits on Jul 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 4bdb5f3 - Browse repository at this point
Copy the full SHA 4bdb5f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f388350 - Browse repository at this point
Copy the full SHA f388350View commit details -
No more including of
cxx_universal.h
The `cxx_universal.h` exists to provide symbols that sqlite_orm depends on everywhere. It is easy to forget to include it. And more importantly there are decision macros used that need to be defined before certain files anyway, which is the reason that `cxx_universal.h` gets included by the files used for amalgamation. Hence I decided to not include it anymore.
Configuration menu - View commit details
-
Copy full SHA for 2927b2b - Browse repository at this point
Copy the full SHA 2927b2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for c08b5c8 - Browse repository at this point
Copy the full SHA c08b5c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for faa3496 - Browse repository at this point
Copy the full SHA faa3496View commit details -
Configuration menu - View commit details
-
Copy full SHA for fb7f62b - Browse repository at this point
Copy the full SHA fb7f62bView commit details
Commits on Jul 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for c059cbd - Browse repository at this point
Copy the full SHA c059cbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5da3ba3 - Browse repository at this point
Copy the full SHA 5da3ba3View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.