Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yet another code quality PR #1337

Merged
merged 15 commits into from
Jul 22, 2024
Merged

Yet another code quality PR #1337

merged 15 commits into from
Jul 22, 2024

Commits on Jul 17, 2024

  1. Added includes of dependent headers

    * Added missing includes of dependent internal headers
    * Cleaned up amalgamation files to only include the public facing high-level headers
    trueqbit committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    26c0b76 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    69b2389 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2024

  1. Configuration menu
    Copy the full SHA
    b81b407 View commit details
    Browse the repository at this point in the history
  2. Added more storage unit tests

    * last insert rowid
    * With insert
    * moved "With select" to storage_tests.cpp
    trueqbit committed Jul 18, 2024
    Configuration menu
    Copy the full SHA
    c4f3770 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Configuration menu
    Copy the full SHA
    b66c348 View commit details
    Browse the repository at this point in the history
  2. Included <sqlite3.h> explicitly in examples and unit tests

    When importing sqlite_orm as a named module, sqlite3 symbols are not exported.
    trueqbit committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    d639111 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    6a96d1c View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. Configuration menu
    Copy the full SHA
    4bdb5f3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f388350 View commit details
    Browse the repository at this point in the history
  3. No more including of cxx_universal.h

    The `cxx_universal.h` exists to provide symbols that sqlite_orm depends on everywhere.
    It is easy to forget to include it. And more importantly there are decision macros used that need to be defined before certain files anyway, which is the reason that `cxx_universal.h` gets included by the files used for amalgamation.
    Hence I decided to not include it anymore.
    trueqbit committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    2927b2b View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    c08b5c8 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    faa3496 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    fb7f62b View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. Configuration menu
    Copy the full SHA
    c059cbd View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5da3ba3 View commit details
    Browse the repository at this point in the history