Issue 29: on_fail action for Mode activation #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add the on_fail params
add basic implementation mode needs still a name
* Accept general **kwargs to be passed to Mode.__init__
pipe the modename all the way from Mode to ActivationResult
* should return after warn * should call the callable
The mode.name is now passed to activate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #29
The modes now receive a
on_failargument:The on fail can either a string or a callable.
"error" (raise wakepy.ActivationError) -- default
"warn" (warnings.warn)
"pass" (do nothing)
callable (custom callable, which takes single argument: ActivationResult)