Support passing AWS session token via environment variable #226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
desync already supports taking aws_session_token from shared credentials file, but it is not convenient to store token there if it is received by another application that will call desync. This commit allows to pass session token via environment variable like other credentials. Co-authored-by: Aleksejs Lucko <lu4ik@yandex-team.ru>
|
Good job! |
folbricht
reviewed
Oct 26, 2022
Most applications and libraries support same environment variables as AWS CLI and AWS SDKs. It will be more convenient if desync will also support them. Co-authored-by: Aleksejs Lucko <lu4ik@yandex-team.ru>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
desync already supports taking
aws_session_tokenfrom shared credentials file, but it is not convenient to store token there if it is received by another application that will call desync. This commit allows to pass session token via environment variable like other credentials.Also while we there, lets add support for the same environment variables as AWS CLI and AWS SDKs accept.
Co-authored-by: Aleksejs Lucko lu4ik@yandex-team.ru