WIP: pane switching keyboard shortcuts - #1709
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zburke
reviewed
Oct 4, 2022
| @@ -3,6 +3,7 @@ import { FormattedMessage } from 'react-intl'; | |||
| import PropTypes from 'prop-types'; | |||
| import queryString from 'query-string'; | |||
| import { hot } from 'react-hot-loader'; | |||
| import { getFirstFocusable } from '@folio/stripes-components/util/getFocusableElements'; | |||
There was a problem hiding this comment.
You can import getFirstFocusable directly from @folio/stripes/components; you don't have to reach in and get it by private path.
zburke
reviewed
Oct 4, 2022
| const modifiedCommands = [...commands, | ||
| { | ||
| name: 'nextPane', | ||
| shortcut: 'shift + pagedown' |
There was a problem hiding this comment.
FYI, no pagedown or pageup keys on a MacOS laptop keyboard. I know I know, WIP, POC, etc.
There was a problem hiding this comment.
Thank you for re-iterating this on this rather ancient POC... For persistence of the conversation, Does fn up/down arrow perform the same function/key as pageup/down? can you shift + fn + arrow on a mac?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements keyboard shortcuts to cycle focus through the visible panes in the ui. It will ultimately be set up to focus the first-focusable element within the pane content. If none are available, it will focus the pane header. It will ultimately be set up to allow for a custom focus target within the Pane. This is a prototype. It isn't centralized. The API is guaranteed to change - this is just to see how it feels to use.
Implement
shift + pagedownandshift + pageupas pane switchers.