don't work so hard; CVE-2023-26115 was fixed upstream #2658
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include `@aashutoshrathi/word-wrap` as a dev-dep in addition to including it in `resolutions` where it is used as an alias to replace the (unmaintained) `word-wrap`. Just like peer-deps, yarn does not satisfy resolution-deps, so if we want that reference in `resolutions` to be resolvable, we need to _actually_ depend on it elsewhere. `word-wrap` is a transitive dep via eslint > optionator, so I added `@aashutoshrathi/word-wrap` as a dev-dep. Additionally, unrelated, it is important to leave `--frozen-lockfile` in the `Run yarn install` instructions. Without it, there's not much point in committing `yarn.lock` because you would be free to update `package.json` by changing versions or even adding new dependencies and CI wouldn't warn you that `yarn.lock` and `package.json` were out of sync. This breaks the promise of reprodicble builds that committing `yarn.lock` provides.
zburke
changed the title
|
manvendra-s-rathore
added a commit
that referenced
this pull request
Mar 15, 2024
* UIU-3072 fix linting issues * fix FeeFineSettings test * fix lint issues * update loanDetails test case * revert LoanDetails test case fix * update changeLog.md * resolve review comments * update build-npm.yml * remove yarn.lock * revert build-npm.yml change * enable yarn.lock file update * updated yarn.lock file * remove empty line * include @aashutoshrathi/word-wrap as a dev-dep (#2657) Include `@aashutoshrathi/word-wrap` as a dev-dep in addition to including it in `resolutions` where it is used as an alias to replace the (unmaintained) `word-wrap`. Just like peer-deps, yarn does not satisfy resolution-deps, so if we want that reference in `resolutions` to be resolvable, we need to _actually_ depend on it elsewhere. `word-wrap` is a transitive dep via eslint > optionator, so I added `@aashutoshrathi/word-wrap` as a dev-dep. Additionally, unrelated, it is important to leave `--frozen-lockfile` in the `Run yarn install` instructions. Without it, there's not much point in committing `yarn.lock` because you would be free to update `package.json` by changing versions or even adding new dependencies and CI wouldn't warn you that `yarn.lock` and `package.json` were out of sync. This breaks the promise of reprodicble builds that committing `yarn.lock` provides. * don't work so hard; CVE-2023-26115 was fixed upstream (#2658) * include @aashutoshrathi/word-wrap as a dev-dep Include `@aashutoshrathi/word-wrap` as a dev-dep in addition to including it in `resolutions` where it is used as an alias to replace the (unmaintained) `word-wrap`. Just like peer-deps, yarn does not satisfy resolution-deps, so if we want that reference in `resolutions` to be resolvable, we need to _actually_ depend on it elsewhere. `word-wrap` is a transitive dep via eslint > optionator, so I added `@aashutoshrathi/word-wrap` as a dev-dep. Additionally, unrelated, it is important to leave `--frozen-lockfile` in the `Run yarn install` instructions. Without it, there's not much point in committing `yarn.lock` because you would be free to update `package.json` by changing versions or even adding new dependencies and CI wouldn't warn you that `yarn.lock` and `package.json` were out of sync. This breaks the promise of reprodicble builds that committing `yarn.lock` provides. * we don't have to work so hard; this was fixed upstream * include @aashutoshrathi/word-wrap version --------- Co-authored-by: Zak Burke <zburke@ebsco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were subject to CVE-2023-26115 via a transitive vulnerability from eslint > optionator > word-wrap. optionator noticed the same vulnerability and made the same fix in
06fd3aso the best thing we can do here is ... nothing.