Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump fontkit and linebreak deps #1367

Merged
merged 10 commits into from
Dec 16, 2024
Merged

Bump fontkit and linebreak deps #1367

merged 10 commits into from
Dec 16, 2024

Conversation

devongovett
Copy link
Member

Published new versions of fontkit and linebreak.

@davecarlson
Copy link

thanks for doing the fontkit updates - is there an ETA for this PR ?

@treylon
Copy link

treylon commented Sep 20, 2022

Would be great to have a new release with this dependency bump

@chris-gaona
Copy link

Is there a timeframe when this PR will be merged & eventually released? There is currently a CVE (link to CVE) for the package minimist that is used in the current released version of this package, 0.13.0. The package, minimist, is used in fontkit@1.8.1, but not in the latest release of fontkit, which would make this CVE an non issue I think.

Screen Shot 2022-10-06 at 4 13 25 PM

@demiankatz
Copy link

Any news on this PR? I'm trying to get rid of core-js deprecation warnings in my project, and I think this may be the key to everything. :-)

@Ayrat-Kh
Copy link

Hello,

Superb library!

I'm wondering if there is any ETA. I'm trying to optimize the bundle size, and dropping iconv-lite from the dependency might improve the bundle size.

@omochi
Copy link

omochi commented Oct 25, 2024

I would appreciate it if you could move this project forward.

I submitted a patch (foliojs/fontkit#349) tofontkit to resolve an issue I found while using pdfkit.

However, the 1.9.x series of fontkit has build issues(foliojs/fontkit#351), which makes it difficult to contribute.
Since this issue is resolved in the 2.0.x series, it would be helpful if this PR allows pdfkit to use the 2.0.x series of fontkit.

Copy link
Collaborator

@diegomura diegomura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@devongovett are you ok if I merge this?

@MickL
Copy link

MickL commented Dec 6, 2024

The PR is 2.5 years old, I guess it will never be merged? @liborm85

@liborm85 liborm85 merged commit f238d1b into master Dec 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.