Add support for spot colors #1464
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aslakhellesoy
commented
Sep 26, 2023
| @@ -1,4 +1,4 @@ | |||
| import diff from 'jest-diff'; | |||
| import { diff } from 'jest-diff'; | |||
There was a problem hiding this comment.
Not strictly related to this PR, but as I was running the tests, my new test initially failed, and I had to change this to make the test error correctly.
This comment was marked as off-topic.
This comment was marked as off-topic.
|
Hi, I think this is highly expected feature. Anyone to resolve conflicts? |
|
@hubertmuller I've merged the latest from |
blikblum
reviewed
Sep 17, 2024
| @@ -40,7 +40,7 @@ class PDFObject { | |||
| static convert(object, encryptFn = null) { | |||
| // String literals are converted to the PDF name type | |||
| if (typeof object === 'string') { | |||
| return `/${object}`; | |||
| return /^[/[(\d].*/.test(object) ? object : `/${object}` | |||
There was a problem hiding this comment.
Can you add unit tests for this change?
|
Resolved by #756 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This adds support for spot colors - see PDF Association and Adobe for details.
A new
PDFDocument.addSpotColormethod has been added:The code was originally written by @ziaenezhad who mentioned it in #756
Then @sekforde submitted #1457 which was closed unmerged.
My code is based on the two contributions above, but I've also added a test, and updated the documentation and changelog. So hopefully this in a more mergable condition.
Checklist: