Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use string instead of bool for IsReplacementOrder in Order model #50

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

Coffeeri
Copy link
Contributor

@Coffeeri Coffeeri commented Dec 22, 2023

This is a quick fix for a known bug in amzn/selling-partner-api-models#2647.
This may be reverted if fix.

+ the type is supposed to be a boolean, however the response is a string

Example:
"HasRegulatedItems": false,
"IsReplacementOrder": "false",
@Coffeeri Coffeeri force-pushed the fix/IsReplacementOrder-string-bool branch from 1bc63fa to 83d7dbe Compare December 22, 2023 09:10
@Coffeeri Coffeeri merged commit 236fbea into main Dec 22, 2023
2 checks passed
@Coffeeri Coffeeri deleted the fix/IsReplacementOrder-string-bool branch December 22, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant