Add Configurable Launch Timeout to Spotify App Launch #424
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request introduces the ability to configure the timeout for launching the Spotify application within spotcast. The primary motivation behind this enhancement is to provide users with more control over the launch process, particularly in varying network conditions where the default timeout may not be sufficient.
Key Changes:
Motivation and Context:
In some environments, the response time from the Spotify app can exceed the previously hard-coded timeout, leading to premature launch failures. By making the timeout configurable, we empower users to tailor the component's behavior to their specific setup, potentially reducing the occurrence of unnecessary errors and improving the overall reliability of the Spotify launch process.
Testing:
I have done testing for myself and it seems to work, please test this yourself before merging.