Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump packages #131

Merged
merged 3 commits into from
Sep 13, 2023
Merged

chore: bump packages #131

merged 3 commits into from
Sep 13, 2023

Conversation

LeoDog896
Copy link
Contributor

@ayuhito
Copy link
Member

ayuhito commented Sep 11, 2023

  • bumps all packages

Happy to accept this PR! One thing to note is that I'm not too keen on updating dependencies in this project anymore since nothing is broken and updating dependencies potentially can break something with no real benefit. Nor are there any security concerns due to the scope of this project. I'll still accept this change though for now.

IIRC, this didn't fix the bug, so I haven't removed it yet despite already updating pkgroll. I think we should revert this change, but otherwise LGTM! 🎉

@LeoDog896
Copy link
Contributor Author

LeoDog896 commented Sep 11, 2023

Odd, pkgroll seems to be adding the shebang in Windows for me (and the CI runs tests on windows as well). I know that it doesn't add it to cli.js, but that file is also unused (also why I asked about it back in discord 😅). Absolutely understand your concerns with updating dependencies, though.

@ayuhito
Copy link
Member

ayuhito commented Sep 13, 2023

Sorry for the delay, I wanted to test this branch to confirm if it is working on Windows but ran into this error due to Got 13 - sindresorhus/got#2267

pkgroll won't compile since it uses rollup-plugin-dts under the hood which needs perfect typing .^^ It might be better to roll back to Got 12 in this case.

Copy link
Member

@ayuhito ayuhito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good now! Thank you! 🎉 Ignore the currently failing lints as that is related to a previous issue. Will need to eventually address that in a future PR.

@ayuhito ayuhito merged commit 91831fb into fontsource:main Sep 13, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants