Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Rails 4 #214

Closed
8 of 9 tasks
wvengen opened this issue Nov 26, 2013 · 3 comments
Closed
8 of 9 tasks

Upgrade to Rails 4 #214

wvengen opened this issue Nov 26, 2013 · 3 comments
Milestone

Comments

@wvengen
Copy link
Member

wvengen commented Nov 26, 2013

Mostly done on branch rails4.

  • Fix config.secret_key_base deprecation
  • Fix other deprecations
  • Make tests work (product distribution fails)
  • Use ransack (instead of outdated meta_search)
  • Check if whitelist_attributes line can be removed in application.rb (no)
  • Check authenticity tokens for remote forms (also what happens without javascript, e.g. invites)
  • Merge master
  • Testing (especially parts that have no tests: wiki, tasks, stock, foodcoop, invoices, member admin)
  • Check if production works

Not all issues may have been caught, especially:

  • Changed order - if you see a weird ordering, please let us know. Rails 4 has reversed the way orderings are combined.
  • Some instances of Relation#includes where #references would be needed
  • Rails 4 has concerns for models and controllers, it may cleanup some things if we start to use them.

See the upgrading to rails 4 book for some background.

@wvengen
Copy link
Member Author

wvengen commented Jan 13, 2014

Foodsoft on rails 4 feels a lot faster - I think it'll be worth the investment. Or perhaps it's just Ruby 2.0.

@wvengen
Copy link
Member Author

wvengen commented Feb 15, 2014

Ok, deployed and working on http://foodsoft-translation.herokuapp.com/ !

wvengen added a commit that referenced this issue Feb 17, 2014
wvengen added a commit that referenced this issue Feb 20, 2014
Conflicts:
	Gemfile.lock
wvengen added a commit that referenced this issue Feb 24, 2014
Conflicts:
	Gemfile.lock
@fsmanuel
Copy link
Contributor

👍 great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants