Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Docker Setup #399

Closed
wants to merge 1 commit into from
Closed

Improved Docker Setup #399

wants to merge 1 commit into from

Conversation

bennibu
Copy link
Contributor

@bennibu bennibu commented Feb 6, 2016

  • Use ruby version 3 with most dependencies already shipped
  • Use bundle container
  • Run rails commands as app user
  • Set Database encoding

Sadly, I couldn't get the test suite to run without some errors. But I guess, this has nothing to do with the docker update as there are also errors in latest travis build.

@benni-as
Updated Docker setup.
aaa6f18 
* Use ruby version 3
* Use bundle container
* Run rails commands as app user
@wvengen
Copy link
Member

wvengen commented Feb 8, 2016

Thanks, looks good! I'll test and merge (tests are currently broken - oops - #400).

@bennibu
Copy link
Contributor Author

bennibu commented Feb 8, 2016

@wvengen I forgot to mention. If you have to migrate from the old docker setup be sure to delete old container stuff (sudo) rm -rf tmp/* log/* and rebuild the container with docker-compose build. Otherwise rails will fail upon missing permissions (in tmp and log files).

@wvengen wvengen force-pushed the master branch 2 times, most recently from 8100b26 to d6bf09b Compare February 18, 2016 22:52
wvengen added a commit that referenced this pull request Feb 23, 2016
@wvengen
Add release note for Docker setup
76ea0cc 
#399 (comment)
@wvengen
Copy link
Member

wvengen commented Feb 24, 2016

Tested and merged, thanks!

@wvengen wvengen closed this Feb 24, 2016
@wvengen
Copy link
Member

wvengen commented Feb 24, 2016

Oh, and I added your notice to the CHANGELOG, so people will (hopefully) catch it when upgrading.

@wvengen wvengen added this to the 4.5 milestone Feb 24, 2016
@bennibu
Copy link
Contributor Author

bennibu commented Feb 25, 2016

Thanks!

wvengen notifications@github.com schrieb:

Oh,andIaddedyournoticetotheCHANGELOG,sopeoplewill(hopefully)catchitwhenupgrading.ReplytothisemaildirectlyorviewitonGitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.5
Development

Successfully merging this pull request may close these issues.
3 participants
@bennibu @wvengen @benni-as