minimal database seed silently fails

[JuliusR]

affected versions

• master (4.7.99)

steps to reproduce

1. setup fresh development environment (clone sources and follow SETUP_DEVELOPMENT.md)
2. make sure that no errors have been printed to the console
3. login to the foodsoft and fill the new-supplier form
4. submit the new-supplier form

expected behavior

The form data are posted, and the supplier is created.

actual behavior

The form data are posted, but the supplier is not created. Instead, the new-supplier form is rendered again. It does not show any validation errors.

[JuliusR]

The problem is caused by a chain of silent failures.

The following seed fails because of a missing financial_transaction_class.

foodsoft/db/seeds/minimal.seeds.rb

Line 30 in 78c4ebc

SupplierCategory.create(:name => "Other")

As a result, SupplierCategory.first is nil such that the following line does not work properly:

foodsoft/app/controllers/suppliers_controller.rb

Line 30 in 78c4ebc

@supplier.supplier_category ||= SupplierCategory.first

Finally, the validation fails. The form is re-rendered in order to show validation errors. However, no validation error is shown in this case (probably because the form does not have an input for the supplier category).

foodsoft/app/controllers/suppliers_controller.rb

Line 31 in 78c4ebc

if @supplier.save