Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rescue on WikiCloth exception #230

Merged

Conversation

JuliusR
Copy link
Contributor

@JuliusR JuliusR commented Dec 22, 2013

See #229.

@wvengen
Copy link
Member

wvengen commented Dec 22, 2013

Nice :) What about moving the alert classes into code (and remove html_safe)?

@JuliusR
Copy link
Contributor Author

JuliusR commented Dec 22, 2013

For me, the html_safe is essential because the rescue happens in the controller. Is it better now?

@wvengen
Copy link
Member

wvengen commented Dec 22, 2013

Thanks, that's a bit easier on the translators 👍

@wvengen
Copy link
Member

wvengen commented Dec 22, 2013

The error is a bit vague though, what about showing the actual error message? Perhaps something like: "I'm sorry to report that an error occured when interpreting the wiki page: %{msg}. Please try to fix it, and save the page again.".
(some wikicloth exceptions)

@JuliusR
Copy link
Contributor Author

JuliusR commented Dec 22, 2013

Yeah, I thought about that. However, since the error message for me does not allow to conclude about the problem, I did not implement it before. Here is my attempt.

wvengen added a commit that referenced this pull request Dec 23, 2013
…icloth-bug

Rescue on WikiCloth exception
@wvengen wvengen merged commit d7f624a into foodcoops:master Dec 23, 2013
@JuliusR JuliusR deleted the workaround-possible-wikicloth-bug branch December 23, 2013 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants