Use FoodsoftConfig[:email_sender] for sender address #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not every email provider allows sending messages from an unauthorized server.
|
Good point: setting the from address for mails from messages is indeed necessary. Still, this breaks replying.
|
|
What does it break exactly? With the Reply-To header a conforming mail client should work like before... |
|
Oh, somehow I missed that. Sorry! |
| @@ -6,6 +6,7 @@ def foodsoft_message(message, recipient) | |||
|
|
|||
| mail subject: "[#{FoodsoftConfig[:name]}] " + message.subject, | |||
| to: recipient.email, | |||
| from: "#{show_user(message.sender)} <#{message.sender.email}>" | |||
| from: "#{show_user(message.sender)} via Foodsoft <#{FoodsoftConfig[:email_sender]}>", | |||
There was a problem hiding this comment.
really? isn't "via" universal?
There was a problem hiding this comment.
For the handful of languages we have right now, probably yes. In general, no. I'd like to be prepared.
There was a problem hiding this comment.
I'd suggest keeping it hardcoded for now, since we have an even bigger problem: The text depends on the language of the sender and not of the recipient.
There was a problem hiding this comment.
True! Let's keep it like this for now.
wvengen
added a commit
that referenced
this pull request
Feb 18, 2015
Use FoodsoftConfig[:email_sender] for sender address
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not every email provider allows sending messages from an unauthorized server.