Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diff for wiki pages #420

Merged
merged 1 commit into from
Mar 7, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions plugins/wiki/app/controllers/pages_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,13 @@ def all
end
end

def diff
@page = Page.find(params[:id])
@old_version = Page::Version.find_by_page_id_and_lock_version params[:id], params[:old]
@new_version = Page::Version.find_by_page_id_and_lock_version params[:id], params[:new]
@diff = Diffy::Diff.new(@old_version.body, @new_version.body).to_s(:html)
end

def version
@page = Page.find(params[:id])
@version = Page::Version.find_by_page_id_and_lock_version params[:id], params[:version]
Expand Down
7 changes: 7 additions & 0 deletions plugins/wiki/app/views/pages/diff.html.haml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
- title t('.title', title: @page.title, old: @old_version.lock_version, new: @new_version.lock_version)

%style= Diffy::CSS
= raw @diff

%hr
= link_to t('ui.back'), 'javascript:history.go(-1)', class: 'btn btn-primary'
16 changes: 10 additions & 6 deletions plugins/wiki/app/views/pages/show.html.haml
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,16 @@
%li= link_to t('.subpages'), "#subpages", 'data-toggle-this' => '#subpages'

#versions.well.well-small{:style => "display:none"}
%h3= t '.title_versions'
%ul.unstyled
- @page.versions.reverse.each do |version|
%li
= link_to I18n.l(version.updated_at, :format => t('.date_format')), version_page_path(@page, :version => version.lock_version)
= "(#{show_user(User.find_by_id(version.updated_by))})"
= form_tag diff_page_path(@page), :method => :get do
%h3= t '.title_versions'
%ul.unstyled
- @page.versions.reverse.each_with_index do |version, index|
%li
= radio_button_tag :old, version.lock_version, index == 1
= radio_button_tag :new, version.lock_version, index == 0
= link_to I18n.l(version.updated_at, :format => t('.date_format')), version_page_path(@page, :version => version.lock_version)
= "(#{show_user(User.find_by_id(version.updated_by))})"
= submit_tag t('.diff'), class: 'btn'

- unless @page.children.empty?
#subpages.well.well-small{:style => "display:none"}
Expand Down
6 changes: 6 additions & 0 deletions plugins/wiki/config/locales/de.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
de:
pages:
diff:
title: "%{title} - Änderung von Version %{old} auf %{new}"
show:
diff: Versionen vergleichen
3 changes: 3 additions & 0 deletions plugins/wiki/config/locales/en.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,8 @@ en:
redirect_notice: Redirected from %{page} ...
destroy:
notice: The page '%{page}' and all subpages have been deleted successfully.
diff:
title: "%{title} - changes from version %{old} to %{new}"
edit:
title: Edit page
error_stale_object: Warning, the page has just been edited by someone else. Please try again.
Expand Down Expand Up @@ -68,6 +70,7 @@ en:
date_format: ! '%d-%m-%y %H:%M'
delete: Delete page
delete_confirm: ! 'Warning: all subpages will be deleted as well. Are you sure?'
diff: Compare versions
edit: Edit page
last_updated: Last updated by <b>%{user}</b> on %{when}
subpages: subpages
Expand Down
1 change: 1 addition & 0 deletions plugins/wiki/config/routes.rb
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
get :all, :on => :collection
get :version, :on => :member
get :revert, :on => :member
get :diff, :on => :member
end
get '/wiki/:permalink' => 'pages#show', :as => 'wiki_page' # , :constraints => {:permalink => /[^\s]+/}
get '/wiki' => 'pages#show', :defaults => {:permalink => 'Home'}, :as => 'wiki'
Expand Down